Skip to content

Fix vscode-radio: use native radio input type#615

Open
msengkhyavong wants to merge 2 commits intovscode-elements:mainfrom
msengkhyavong:maylinas/radioButtonInputType
Open

Fix vscode-radio: use native radio input type#615
msengkhyavong wants to merge 2 commits intovscode-elements:mainfrom
msengkhyavong:maylinas/radioButtonInputType

Conversation

@msengkhyavong
Copy link
Copy Markdown

Fixes #612: #612

  • Internal inside is now type="radio" instead of "checkbox"
  • Screen readers announce "radio button" instead of "checkbox"
  • Manual verification done via DevTools + Windows Narrator

Tested via via /dev/vscode-radio-group/checked.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vscode-radio is announced as “checkbox” and may announce both “checked” and “unchecked” in Windows screen readers

1 participant